Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove datasetIDs from metricsRequest object #2013

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

etaques
Copy link
Contributor

@etaques etaques commented Nov 16, 2022

This PR removes datasetIDs from metricsRequest (otel) attributes, to be sent to prometheus without dataset_ids attribute on metrics

Metrics attributes before change:
image

Metrics attributes after change:
image

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Base: 60.68% // Head: 60.48% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (a9b86ec) compared to base (732b9b3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2013      +/-   ##
===========================================
- Coverage    60.68%   60.48%   -0.20%     
===========================================
  Files           70       70              
  Lines         4891     4907      +16     
===========================================
  Hits          2968     2968              
- Misses        1923     1939      +16     
Impacted Files Coverage Δ
sinker/otel/orbreceiver/otlp.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@etaques etaques requested a review from lpegoraro November 16, 2022 15:28
@etaques etaques requested a review from lpegoraro November 16, 2022 15:57
Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etaques etaques merged commit ce53f22 into develop Nov 16, 2022
@etaques etaques deleted the delete-datasetids branch November 16, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants