Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make config field mandatory on sinks creation #2112

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

mclcavalcante
Copy link
Contributor

Make sink config mandatory on sink creation and check if it has the minimum amount of keys to create

*Plus make some unit tests more readable

@mclcavalcante mclcavalcante self-assigned this Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Base: 4.91% // Head: 64.00% // Increases project coverage by +59.08% 🎉

Coverage data is based on head (c2f7a20) compared to base (7ef874b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2112       +/-   ##
============================================
+ Coverage     4.91%   64.00%   +59.08%     
============================================
  Files           15       61       +46     
  Lines         1057     4601     +3544     
============================================
+ Hits            52     2945     +2893     
- Misses        1005     1656      +651     
Impacted Files Coverage Δ
fleet/postgres/agent_groups.go 81.88% <100.00%> (ø)
sinks/api/http/requests.go 98.30% <100.00%> (ø)
sinks/postgres/sinks.go 73.41% <100.00%> (ø)
agent/backend/pktvisor/pktvisor.go
agent/otel/otlpmqttexporter/config.go
agent/backend/pktvisor/scrape.go
agent/otel/otlpmqttexporter/factory.go
agent/heartbeats.go
agent/otel/pktvisorreceiver/factory.go
agent/otel/pktvisorreceiver/receiver.go
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mclcavalcante mclcavalcante merged commit 088bee1 into develop Dec 27, 2022
@mclcavalcante mclcavalcante deleted the fix/make-sink-config-mandatory-create branch December 27, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants