Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORB-224] partial updates for datasets #2144

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

mclcavalcante
Copy link
Contributor

Support updates on datasets API to name and sinks ids without requiring the other fields to be provided in the JSON body:

Both cases follow the rules:

  • If it is informed, the new one must overwrite the old one
  • If it is omitted, the old one must be maintained.
  • If it is informed with empty or invalid values, an error must be raised informing that the attribute doesn't match the pattern required.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 64.29% // Head: 64.36% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (6ea0432) compared to base (d646d28).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2144      +/-   ##
===========================================
+ Coverage    64.29%   64.36%   +0.07%     
===========================================
  Files           61       61              
  Lines         4638     4650      +12     
===========================================
+ Hits          2982     2993      +11     
- Misses        1656     1657       +1     
Impacted Files Coverage Δ
policies/api/grpc/endpoint.go 47.72% <ø> (ø)
policies/postgres/policies.go 76.81% <ø> (ø)
policies/api/http/endpoint.go 94.87% <66.66%> (-1.13%) ⬇️
policies/api/http/requests.go 93.75% <100.00%> (+0.20%) ⬆️
policies/policy_service.go 88.80% <100.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mclcavalcante mclcavalcante merged commit 651e7b1 into develop Jan 16, 2023
@mclcavalcante mclcavalcante deleted the fix/datasets-partial-update branch January 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants