Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests to validate metrics scraped by handler and metric groups #2145

Merged
merged 4 commits into from
Jan 18, 2023
Merged

tests to validate metrics scraped by handler and metric groups #2145

merged 4 commits into from
Jan 18, 2023

Conversation

manrodrigues
Copy link
Contributor

No description provided.

@manrodrigues manrodrigues added the test QA tests label Jan 13, 2023
@manrodrigues manrodrigues self-assigned this Jan 13, 2023
@manrodrigues manrodrigues marked this pull request as ready for review January 16, 2023 15:48
leoparente
leoparente previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etaques
etaques approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manrodrigues manrodrigues merged commit 601ae47 into develop Jan 18, 2023
@manrodrigues manrodrigues deleted the feature-ORB-290-test_metric_groups branch January 18, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etaques etaques etaques approved these changes

@leoparente leoparente leoparente left review comments

Assignees

@manrodrigues manrodrigues

Labels
test QA tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manrodrigues @leoparente @etaques