Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORB-170] add 'noTapMatch' state for policies on agent #2149

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

mclcavalcante
Copy link
Contributor

Add a new policy state when a policy isn't applied because tap selector doesn't match any available taps
image

@codecov-commenter
Copy link

Codecov Report

Base: 64.29% // Head: 4.91% // Decreases project coverage by -59.39% ⚠️

Coverage data is based on head (e7e7bd4) compared to base (d646d28).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #2149       +/-   ##
===========================================
- Coverage    64.29%   4.91%   -59.39%     
===========================================
  Files           61      15       -46     
  Lines         4638    1058     -3580     
===========================================
- Hits          2982      52     -2930     
+ Misses        1656    1006      -650     
Impacted Files Coverage Δ
...inker/otel/kafkafanoutexporter/jaeger_marshaler.go
sinker/otel/kafkafanoutexporter/config.go
sinks/api/http/transport.go
fleet/api/http/metrics.go
fleet/api/http/transport.go
fleet/service.go
policies/api/http/transport.go
sinks/sinks_service.go
policies/service.go
sinks/service.go
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mclcavalcante mclcavalcante merged commit ef7ca2c into develop Jan 19, 2023
@mclcavalcante mclcavalcante deleted the agent/implement-no-match-policy-status branch January 19, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants