Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iteration #2193

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix iteration #2193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
013b711
fix(maestro): fix iteration to be more performatic and less error prone.
lpegoraro Feb 9, 2023
755a707
fix(maestro): fix nil reference error
lpegoraro Feb 9, 2023
7f6ae8b
Merge branch 'develop' into fix_iteration
lpegoraro Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions maestro/monitor/monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ func (svc *monitorService) monitorSinks(ctx context.Context) {
for _, collector := range runningCollectors {
var sink *sinkspb.SinkRes
for _, sinkRes := range sinksRes.Sinks {
svc.logger.Info("Debug collector name, collector id", zap.String("name", collector.Name), zap.Any("collector", collector))
if strings.Contains(collector.Name, sink.Id) {
svc.logger.Info("Debug collector name, collector id", zap.String("name", collector.Name), zap.String("sinkID", sinkRes.Id))
if strings.Contains(collector.Name, sinkRes.Id) {
sink = sinkRes
break
}
Expand Down