Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat/fix): Enable Partial Sink Update #2230

Merged
merged 7 commits into from
May 9, 2023
Merged

(feat/fix): Enable Partial Sink Update #2230

merged 7 commits into from
May 9, 2023

Conversation

gpazuch
Copy link
Contributor

@gpazuch gpazuch commented Feb 17, 2023

Add new component/screen for viewing and editing Sinks.

Allows user to edit sink's details and tags without changing or reentering sink backend configuration and password

@gpazuch gpazuch requested a review from manrodrigues February 17, 2023 18:53
@gpazuch gpazuch self-assigned this Feb 17, 2023
@gpazuch
Copy link
Contributor Author

gpazuch commented Feb 17, 2023

@manrodrigues couple of issues I'm fixing before merge:

  • shows inexistent tag when no tags are present in the sink
  • needs styling improvements:
    • fix each section dimensions
    • make it responsive
  • should allow for backend change (? is/should it be possible to change backend ?)

@manrodrigues
Copy link
Contributor

@manrodrigues couple of issues I'm fixing before merge:

  • shows inexistent tag when no tags are present in the sink

  • needs styling improvements:

    • fix each section dimensions
    • make it responsive
  • should allow for backend change (? is/should it be possible to change backend ?)

We'll have the otlp exporter that Leo is working on.. but I don't know how much responsible it should be or even if we should be able to change from one to another. We need to check it with Leo and Richard, probably.

@gpazuch
Copy link
Contributor Author

gpazuch commented Mar 29, 2023

@manrodrigues couple of issues I'm fixing before merge:

  • shows inexistent tag when no tags are present in the sink

hey, I just noticed that for sinks created through the batch creation, there are tags being set as empty strings for key value pairs, like the one below

{"id":"1da75ad8-d87e-405a-b1c3-767a8535cba2","name":"test_sink_label_name_AgHqDYgKLl","description":"","tags":{"":""},"state":"unknown","backend":"prometheus","config":{"migrated":"m3","opentelemetry":"enabled","password":"","remote_host":"https://prometheus-prod-10-prod-us-central-0.grafana.net/api/prom/push","username":"443932"},"ts_created":"2023-02-13T20:48:07.198133Z"}

image

Copy link
Contributor

@manrodrigues manrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpazuch gpazuch merged commit 52234c7 into develop May 9, 2023
@gpazuch gpazuch deleted the feat/sink-view branch May 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants