Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build:ui): read GTAG from environment variable #2274

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

gpazuch
Copy link
Contributor

@gpazuch gpazuch commented Mar 20, 2023

Changed https://github.com/orb-community/orb/blob/develop/ui/scripts/setenv.ts to read GTAGID value from environment and write it to https://github.com/orb-community/orb/blob/develop/ui/src/environments/environment.env.ts upon build.

[] requires GTAGID to be defined on build environment

@gpazuch gpazuch self-assigned this Mar 20, 2023
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpazuch gpazuch merged commit 3509223 into develop Mar 22, 2023
@gpazuch gpazuch deleted the fix/ui-gtag branch March 22, 2023 20:32
gpazuch added a commit that referenced this pull request Mar 29, 2023
* fix(build:ui): read GTAG from environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants