Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus auto-discovery on otelcollector #2306

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

etaques
Copy link
Contributor

@etaques etaques commented Apr 12, 2023

This PR activate prometheus auto-discovery for otelcollectors provisioned after this change

@etaques etaques requested a review from lpegoraro April 12, 2023 20:07
@codecov-commenter
Copy link

Codecov Report

Merging #2306 (6f37eee) into develop (033bf06) will increase coverage by 11.95%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##           develop    #2306       +/-   ##
============================================
+ Coverage    52.04%   63.99%   +11.95%     
============================================
  Files           77       62       -15     
  Lines         6076     4858     -1218     
============================================
- Hits          3162     3109       -53     
+ Misses        2914     1749     -1165     
Impacted Files Coverage Δ
maestro/config/config_builder.go 29.16% <ø> (ø)

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@etaques etaques requested a review from leoparente April 12, 2023 20:36
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etaques etaques merged commit b5b0a6a into develop Apr 12, 2023
@etaques etaques deleted the add-metrics branch April 12, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants