Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orb 208 fix #2309

Merged
merged 8 commits into from
Apr 18, 2023
Merged

Orb 208 fix #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9a5c978
fix(orb-ui): #151 - fix name labels for sink and policy
joaoguilherme2003 Mar 23, 2023
0f163e4
fix(orb-ui): tooltip correction on policy view page
joaoguilherme2003 Mar 27, 2023
cb2a483
fix(orb-ui): URL on See Here button on agent credentials
joaoguilherme2003 Apr 3, 2023
1f88644
fix(orb-ui): #199 remove asterisk policy view
joaoguilherme2003 Apr 4, 2023
af43ce2
fix(orb-ui): #208 fix label width on dataset details forms
joaoguilherme2003 Apr 10, 2023
31b9ce1
fix(orb-ui): #192 remove green colors in selectors
joaoguilherme2003 Apr 14, 2023
8ea1beb
fix(orb-ui): orb 208
joaoguilherme2003 Apr 18, 2023
e629858
Merge branch 'develop' into orb-208-fix
joao-mendonca-encora Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ui/src/app/pages/datasets/dataset-from/dataset-from.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,11 @@

<input
(input)="onChangeGroupName($event)"
class="dataset-agent-group-input"
class="dataset-agent-group-input input-agent-group"
[readonly]="fetchedData && !(availableAgentGroups.length > 0)"
[nbAutocomplete]="autoControl"
formControlName="agent_group_name"
[status]="form?.controls.agent_group_name.touched ? (!form.controls.agent_group_name.valid ? 'danger' : 'success') : 'basic'"
nbInput
fullWidth="true"
placeholder="Agent Group"
type="text"
/>
Expand All @@ -55,7 +53,7 @@

</nb-autocomplete>
<div *ngIf="form.controls?.agent_group_id.invalid
&& (form.controls?.agent_group_name.dirty)"
&& (form.controls?.agent_group_name.dirty)"
class="required">
<div *ngIf="form.controls?.agent_group_id.errors?.required">
You must select a valid Agent Group.
Expand All @@ -81,7 +79,6 @@
data-orb-qa-id="agent_policy_id"
formControlName="agent_policy_id"
[status]="form?.controls.agent_policy_id.touched ? (!form.controls.agent_policy_id.valid ? 'danger' : 'success') : 'basic'"
fullWidth="true"
placeholder="Policy"
size="medium"
>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/pages/datasets/dataset-from/dataset-from.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,5 +218,5 @@ nb-accordion {
}

.input-agent-group {
width: 592px;
width: 100%;
}
1 change: 0 additions & 1 deletion ui/src/app/pages/datasets/policies.agent/add/agent.policy.add.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ <h4>{{ isEdit ? 'Edit Agent Policy' : 'Create Agent Policy'}}</h4>
data-orb-qa-id="backend"
formControlName="backend"
fullWidth="true"
[status]="detailsFG?.controls.backend.touched ? (!detailsFG.controls.backend.valid ? 'danger' : 'success') : 'basic'"
placeholder="Select backend type"
size="medium"
>
Expand Down
1 change: 0 additions & 1 deletion ui/src/app/pages/sinks/add/sink.add.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ <h4>{{strings.sink[isEdit ? 'edit' : 'add']['header']}}</h4>
data-orb-qa-id="backend"
formControlName="backend"
fullWidth="true"
[status]="firstFormGroup?.controls.backend.touched ? (!firstFormGroup.controls.backend.valid ? 'danger' : 'success') : 'basic'"
placeholder="Select backend type"
size="medium"
>
Expand Down