Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow invalid ordinals #66

Closed
casey opened this issue Jan 28, 2022 · 0 comments · Fixed by #95
Closed

Allow invalid ordinals #66

casey opened this issue Jan 28, 2022 · 0 comments · Fixed by #95

Comments

@casey
Copy link
Collaborator

casey commented Jan 28, 2022 •
edited
Loading

I think statically checking that ordinals are in range is a bad idea. Ordinal range of post-subsidy blocks can't be represented, it makes the code messier, it forces starting_ordinal functions to return an option, etc. I think I should just do validation on the edges but not in the code.

Also make last name a and not ``, so that we can represent the ending range of names as [,)
@casey casey linked a pull request Feb 1, 2022 that will close this issue
Allow invalid ordinals #95
Merged
@casey casey closed this as completed in #95 Feb 1, 2022
yann-sjtu pushed a commit to okx/ord that referenced this issue Dec 18, 2023
@wanyvic
fix api spec (ordinals#66)
314c934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow invalid ordinals ordinals/ord
1 participant
@casey