Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load wallet automatically 2.0 #1260

Merged
merged 13 commits into from
Jan 16, 2023
Merged

Load wallet automatically 2.0 #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7da293e
load wallet automatically
raphjaph Jan 12, 2023
f3e1771
Merge remote-tracking branch 'upstream/master' into load-wallet-autom…
raphjaph Jan 12, 2023
45a55fc
add wallet path to all rpc paths
raphjaph Jan 16, 2023
08395d2
add test
raphjaph Jan 16, 2023
fcbbfb8
check name
raphjaph Jan 16, 2023
e6e9e7a
tweaks
raphjaph Jan 16, 2023
a33aedf
Merge branch 'master' of https://github.com/casey/ord into load-walle…
raphjaph Jan 16, 2023
fb00ce4
stash
raphjaph Jan 16, 2023
0b285b8
Merge remote-tracking branch 'upstream/master' into load-wallet-autom…
raphjaph Jan 16, 2023
7b3a6dc
properly kill child processes
raphjaph Jan 16, 2023
4cc14d2
tweaks
raphjaph Jan 16, 2023
2f427a3
tweaks 2.0
raphjaph Jan 16, 2023
fc6c27e
tweaks 3.0
raphjaph Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/subcommand/preview.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ struct KillOnDrop(process::Child);

impl Drop for KillOnDrop {
fn drop(&mut self) {
Command::new("kill")
.arg("-SIGINT")
.arg(self.0.id().to_string())
.spawn()
.expect("failed to SIGINT kill process");
self.0.kill().unwrap()
}
}

Expand Down
8 changes: 4 additions & 4 deletions tests/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ struct KillOnDrop(std::process::Child);

impl Drop for KillOnDrop {
fn drop(&mut self) {
Command::new("kill")
.arg("-SIGINT")
assert!(Command::new("kill")
.arg(self.0.id().to_string())
.spawn()
.expect("failed to SIGINT kill process");
.status()
.unwrap()
.success());
}
}

Expand Down