Add mp4 support #1419

cryptoquick · 2023-01-30T03:14:48Z

cryptoquick · 2023-01-30T03:35:47Z

After running the server, I just realized why you don't like "illicit NFT" formats. I think you basically have to reindex, lol

casey · 2023-01-30T05:19:32Z

@cryptoquick I want to do a check that the client only allows H.264 in MP4 when it uploads. If you want to look into doing that feel free, I think there's an MP4 parsing crate somewhere, otherwise feel free to leave this open and I can add that later.

You shouldn't have to reindex, illicit content types are indexed just fine, it's just the frontent that doesn't show them. However, we did change the database schema on master, so that might be what you're running into.

cryptoquick · 2023-01-30T05:27:04Z

Can you tell why this didn't load?
https://ordinals.com/inscription/2b6421c68f123e6332700133d842e14346cf2bdcda5c660465c4b3ee0f78284ei0

casey · 2023-01-30T05:48:15Z

Yup, video/mp4 is an unsupported content type (not present in table in media.rs), so the server uses PreviewUnknownHtml when serving /preview, which is just an empty page.

We could add it to the media.rs table, but not give it a file extension. This would allow inscriptions with type video/mp4 to be previewed, but ord would still not allow publishing them, because files would have an unrecognized extension.

Then later when we check the codec in .mp4s when inscribing, we can add the .mp4 extension to the media table so that they can be inscribed without having to hack the client.

casey · 2023-01-30T05:48:37Z

See the route in server.rs for /preview. (I think it's just fn preview.)

src/media.rs

Co-authored-by: Casey Rodarmor <[email protected]>

cryptoquick · 2023-01-30T06:37:57Z

What I saw in preview was really weird to me. Maybe good for testing? I couldn't figure out what it was for or how to use it.

Also, just so I don't assume, why the h264 requirement? Compatibility?

casey · 2023-01-30T07:14:22Z

Also, just so I don't assume, why the h264 requirement? Compatibility?

Yah, that's correct. Cross-browser compatibility of containers and codecs is really bad. The reasonable choices for good compatibility are H.264 in MP4 and VP8/VP9/AV1 in WebM. MP4 is containers used with many codecs, and many of those codecs are unsupported. In particular, MP4 is often used with HEVC, which both doesn't have great support (doesn't work in firefox for example) and is patent encumbered. WebM though, even though it's a container, not a codec, is almost always used with broadly supported codecs.

A user might preview a HEVC in MP4 inscription with their browser, but then find that many other browsers won't display it after publishing it.

cryptoquick · 2023-01-30T07:20:04Z

It's looking like adding the codec check is actually gonna be pretty easy, I should have a commit for that soon.

casey

Some comments!

casey · 2023-01-30T08:11:14Z

src/inscription.rs

+    let extension = path
+      .extension()
+      .ok_or_else(|| anyhow!("file must have extension"))?
+      .to_str()
+      .ok_or_else(|| anyhow!("unrecognized extension"))?;
+
+    if extension == "mp4" {
+      Media::check_mp4_codec(path)?;
+    }
+
+    let content_type = Media::content_type_for_extension(extension)?;


Let's move these three checks into Media::content_type_for_path, e.g. extract the extension, check the codecs, and then return the Media value.

Good thinking! That'll be cleaner. I'll rename the method, and do as you suggested.

casey · 2023-01-30T08:11:21Z

src/media.rs

+  #[test]
+  fn check_mp4_codec() {
+    assert!(
+      Media::check_mp4_codec(Path::new("bitcoin-pup.mp4")).is_ok(),


We could use a negative test too, to check that an MP4 with an unsupported video codec fails the check.

I'll look into it.

casey · 2023-01-30T08:14:35Z

src/media.rs

+      if let TrackType::Video = track.track_type()? {
+        if let MediaType::H264 = track.media_type()? {
+          return Ok(());
+        } else {
+          return Err(anyhow!("h264 format supported, only"));
+        }


I have no idea what can go into an MP4, but let's check all tracks, and also put the unsupported media type in the error message:

if let TrackType::Video = track.track_type()? { let media_type = track.media_type()?; if let MediaType::H264 != media_type { return Err(anyhow!("Unsupported video codec, only H.264 is supported in MP4s: {media_type}")); }

If you look at the enums for either TrackType and MediaType, I believe this code will behave as expected... So long as any one of the video tracks doesn't contain something that isn't encoded as h264, it returns Ok, otherwise, it returns an error.

That said, it's a good suggestion to return the media type.

I just realized, the code I had before had slightly different logic than when I explained what I wanted... I'm gonna redo some of that logic also.

… mp4 codec detection logic. Add negative mp4 test case.

cryptoquick · 2023-02-02T22:33:04Z

@casey icymi, this pr is rfr

casey · 2023-02-03T04:04:43Z

@cryptoquick Nice, thanks for the ping! I tweaked a little, just the tests. I moved the example files into examples/ with descriptive filenames, and split up the tests into two with descriptive names. Also sorted the media table, and fixed a test which broke because it was expecting only valid inscriptions in examples/. Hope you don't mind!

Thanks for this, vv nice addition ❤️

Add mp4 to supported media types.

bfd3406

casey reviewed Jan 30, 2023

View reviewed changes

src/media.rs Show resolved Hide resolved

Update src/media.rs

ec16a2f

Co-authored-by: Casey Rodarmor <[email protected]>

Merge branch 'master' into mp4

e944e38

cryptoquick force-pushed the mp4 branch from 2da23d1 to 828ce13 Compare January 30, 2023 07:35

Add method to check if mp4 codec is h264.

213ecc2

cryptoquick force-pushed the mp4 branch from 828ce13 to 213ecc2 Compare January 30, 2023 07:36

cryptoquick requested a review from casey January 30, 2023 07:37

casey reviewed Jan 30, 2023

View reviewed changes

Refactor content_type_for_extension -> content_type_for_path. Correct…

847c4fe

… mp4 codec detection logic. Add negative mp4 test case.

cryptoquick requested a review from casey January 30, 2023 22:57

cryptoquick and others added 3 commits January 30, 2023 18:10

Merge branch 'master' into mp4

1c2c1ad

Merge branch 'master' into mp4

22ad233

Merge branch 'master' into mp4

4ff9c13

cryptoquick changed the title ~~Add mp4 to supported media types.~~ Add mp4 support Feb 1, 2023

cryptoquick added 2 commits February 1, 2023 16:41

Merge branch 'master' into mp4

4c9d97c

Merge branch 'master' into mp4

e4f8540

casey added 4 commits February 2, 2023 19:42

Merge remote-tracking branch 'origin/master' into mp4

75c6ad7

Refactor tests and use files in examples

b2261f7

Sort media table

7093ea1

tweak

69b6d38

casey enabled auto-merge (squash) February 3, 2023 03:49

casey added 2 commits February 2, 2023 19:56

Skip previewing av1.mp4

17f9b86

tweak

5d1e17b

casey merged commit 0ded5d8 into ordinals:master Feb 3, 2023

cryptoquick deleted the mp4 branch February 4, 2023 09:35

popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025

Support MP4 inscriptions (ordinals#1419)

a8b4f9f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mp4 support #1419

Add mp4 support #1419

cryptoquick commented Jan 30, 2023 •

edited

Loading

cryptoquick commented Jan 30, 2023 •

edited

Loading

casey commented Jan 30, 2023

cryptoquick commented Jan 30, 2023

casey commented Jan 30, 2023

casey commented Jan 30, 2023

cryptoquick commented Jan 30, 2023

casey commented Jan 30, 2023

cryptoquick commented Jan 30, 2023

casey left a comment

casey Jan 30, 2023

cryptoquick Jan 30, 2023

casey Jan 30, 2023

cryptoquick Jan 30, 2023

casey Jan 30, 2023

cryptoquick Jan 30, 2023

cryptoquick Jan 30, 2023

cryptoquick commented Feb 2, 2023

casey commented Feb 3, 2023

Add mp4 support #1419

Add mp4 support #1419

Conversation

cryptoquick commented Jan 30, 2023 • edited Loading

cryptoquick commented Jan 30, 2023 • edited Loading

casey commented Jan 30, 2023

cryptoquick commented Jan 30, 2023

casey commented Jan 30, 2023

casey commented Jan 30, 2023

cryptoquick commented Jan 30, 2023

casey commented Jan 30, 2023

cryptoquick commented Jan 30, 2023

casey left a comment

Choose a reason for hiding this comment

casey Jan 30, 2023

Choose a reason for hiding this comment

cryptoquick Jan 30, 2023

Choose a reason for hiding this comment

casey Jan 30, 2023

Choose a reason for hiding this comment

cryptoquick Jan 30, 2023

Choose a reason for hiding this comment

casey Jan 30, 2023

Choose a reason for hiding this comment

cryptoquick Jan 30, 2023

Choose a reason for hiding this comment

cryptoquick Jan 30, 2023

Choose a reason for hiding this comment

cryptoquick commented Feb 2, 2023

casey commented Feb 3, 2023

cryptoquick commented Jan 30, 2023 •

edited

Loading

cryptoquick commented Jan 30, 2023 •

edited

Loading