Enable collections/provenance through parent inscriptions method #1869

raphjaph · 2023-03-04T01:15:33Z

Implementation work on #783, look there for more information.

src/inscription.rs

Co-authored-by: ericatallah <[email protected]>

…llections

veryordinally · 2023-03-08T19:11:30Z

ord wallet inscribe is still broken with this PR:

error: Failed to send reveal transaction
because: JSON-RPC error: RPC error response: RpcError { code: -26, message: "non-mandatory-script-verify-flag (Invalid Schnorr signature)", data: None }

``` error: Failed to send reveal transaction because: JSON-RPC error: RPC error response: RpcError { code: -26, message: "non-mandatory-script-verify-flag (Invalid Schnorr signature)", data: None } ```

``` thread 'main' panicked at 'signature hash should compute: PrevoutKind', src/subcommand/wallet/inscribe.rs:360:8 ```

…llections

wagmiwiz · 2023-03-09T12:33:38Z

src/inscription.rs


 #[derive(Debug, PartialEq, Clone)]
 pub(crate) struct Inscription {
-  body: Option<Vec<u8>>,
+  parent: Option<InscriptionId>,


This is a more general point, but I was curious if there is a technical reason behind having only a single parent (vs. a list of 1 or more)?

I understand that in most cases people may want just one but there are also lots of usecases where you may want more than one. A basic example is a mashup (I take one inscription and another inscription and create a new mashup art). A more advanced example is "crafting", where I may take some set of inscriptions as parents, create a child, and burn the parents (all in one tx).

reveal TX for inscriptions containing a parent.

veryordinally · 2023-03-10T12:38:40Z

After some deep-diving on decoding the partially signed and fully signed reveal TXs when inscribing with a parent, I found that sign_raw_transaction_with_wallet apparently removes our inscription data from the witness data. Need to dig deeper to find out why.

@raphjaph @casey it would be great to catch this in tests, but I wasn't sure how to best fit this kind of test into the testing framework. Happy to discuss.

…llections

ericatallah · 2023-03-10T18:59:05Z

src/subcommand/wallet/inscribe.rs

@@ -278,7 +382,7 @@ impl Inscribe {
    );

    let witness = sighash_cache
-      .witness_mut(0)
+      .witness_mut(commit_input_offset)
      .expect("getting mutable witness reference should work");
    witness.push(signature.as_ref());


When inscribing with a parent, do we need to encode the signature with the proper SigHashType before adding to the witness?

let encoded_sig = SchnorrSig { sig: signature, hash_ty: SchnorrSighashType::AllPlusAnyoneCanPay }; witness.push(encoded_sig.serialize());

ericatallah · 2023-03-10T19:29:50Z

src/inscription.rs

+          None => None,
+          Some(bytes) => {
+            if bytes.len() != 36 {
+              return Err(InscriptionError::InvalidInscription)


Might just ignore and return None here instead of throwing Error.

Yep, this part unfinished, but you're right, we should gracefully ignore malformed inscriptions.

@ericatallah

… parent Thanks @ericatallah ! c46d003

src/inscription.rs

felipelincoln · 2023-03-10T20:01:07Z

src/index/entry.rs

+      let array = [
+        head_array[0],
+        head_array[1],
+        head_array[2],
+        head_array[3],
+        head_array[4],
+        head_array[5],
+        head_array[6],
+        head_array[7],
+        head_array[8],
+        head_array[9],
+        head_array[10],
+        head_array[11],
+        head_array[12],
+        head_array[13],
+        head_array[14],
+        head_array[15],
+        tail_array[0],
+        tail_array[1],
+        tail_array[2],
+        tail_array[3],
+        tail_array[4],
+        tail_array[5],
+        tail_array[6],
+        tail_array[7],
+        tail_array[8],
+        tail_array[9],
+        tail_array[10],
+        tail_array[11],
+        tail_array[12],
+        tail_array[13],
+        tail_array[14],
+        tail_array[15],
+        index_array[0],
+        index_array[1],
+        index_array[2],
+        index_array[3],
+      ];


A suggestion to improve code readability:

Suggested change

let array = [

head_array[0],

head_array[1],

head_array[2],

head_array[3],

head_array[4],

head_array[5],

head_array[6],

head_array[7],

head_array[8],

head_array[9],

head_array[10],

head_array[11],

head_array[12],

head_array[13],

head_array[14],

head_array[15],

tail_array[0],

tail_array[1],

tail_array[2],

tail_array[3],

tail_array[4],

tail_array[5],

tail_array[6],

tail_array[7],

tail_array[8],

tail_array[9],

tail_array[10],

tail_array[11],

tail_array[12],

tail_array[13],

tail_array[14],

tail_array[15],

index_array[0],

index_array[1],

index_array[2],

index_array[3],

];

let array = vec![

&head_array[0..=15],

&tail_array[0..=15],

&index_array[0..=3]

].concat().try_into().unwrap();

…llections

Ignore malformed inscriptions. Co-authored-by: Clarke Benedict <[email protected]>

ericatallah · 2023-03-11T09:00:16Z

I've been having trouble getting a child inscription to render properly in the explorer. Looks like a few inscription indexes were hard coded to 0. Not sure if there are more though. Here is a minor fix, hope it helps:
raphjaph#3

@ericatallah

Indirect pull from https://github.com/raphjaph/ord/pull/3/commits Props to @ericatallah for contributing this

veryordinally · 2023-03-11T14:00:28Z

Making progress. For anyone watching, this code does NOT meet our usual quality criteria yet, by far - lots of tests missing and some places are just held together by string. Anyone tempted to try this, this code may work, but be aware that using this on live wallets may lead to loss of inscriptions or other unpredictable outcomes.

clrke · 2023-03-15T06:33:25Z

tests/lib.rs

@@ -43,6 +43,7 @@ struct Inscribe {
  inscription: String,
  reveal: Txid,
  fees: u64,
+  parent: Option<String>,


Suggested change

parent: Option<String>,

#[allow(dead_code)]

parent: Option<String>,

This is just so that the IDE doesn't show warnings that inscribe.parent isn't being used.

raphjaph · 2023-04-13T13:32:00Z

Closing because #1963 is the most up to date

raphjaph added 5 commits March 1, 2023 19:25

enable collections through parent inscriptions method ordinals#783

db29dbc

Update src/inscription.rs

d108043

Update src/inscription.rs

1253365

review changes

33cf4b5

stash

a43c376

raphjaph mentioned this pull request Mar 4, 2023

Collections and Provenance #783

Closed

stash

c781e55

ericatallah reviewed Mar 7, 2023

View reviewed changes

src/inscription.rs Outdated Show resolved Hide resolved

raphjaph and others added 8 commits March 7, 2023 20:20

Update src/inscription.rs

d2eee55

Co-authored-by: ericatallah <[email protected]>

merging

fe5d9d8

Merge branch 'collections' of https://github.com/raphjaph/ord into co…

9025ffa

…llections

small clean up

1bd6333

stashing

af9344e

stash

96a08c2

quick fix

01bc48e

fixed database stuff

a5029a9

Ordinally and others added 5 commits March 8, 2023 20:25

Fix sighashflag issue

ff6c809

``` error: Failed to send reveal transaction because: JSON-RPC error: RPC error response: RpcError { code: -26, message: "non-mandatory-script-verify-flag (Invalid Schnorr signature)", data: None } ```

Fix signature error

340fdef

``` thread 'main' panicked at 'signature hash should compute: PrevoutKind', src/subcommand/wallet/inscribe.rs:360:8 ```

refector re-inscription handling

ca16f44

More robust parsing

791e21c

Merge branch 'collections' of https://github.com/raphjaph/ord into co…

aef890b

…llections

wagmiwiz reviewed Mar 9, 2023

View reviewed changes

Add temporary debug logging and TODO regarding bug in building the

4e4cf9f

reveal TX for inscriptions containing a parent.

raphjaph added 2 commits March 10, 2023 10:07

inscription index now correct

24f5bdb

Merge branch 'collections' of https://github.com/raphjaph/ord into co…

1aa8238

…llections

ericatallah reviewed Mar 10, 2023

View reviewed changes

Encode schnorr signature with proper sighashtype when inscribing with…

1f33ff7

… parent Thanks @ericatallah ! c46d003

clrke reviewed Mar 10, 2023

View reviewed changes

src/inscription.rs Outdated Show resolved Hide resolved

felipelincoln reviewed Mar 10, 2023

View reviewed changes

raphjaph and others added 4 commits March 10, 2023 12:54

stash

5f82a48

Merge branch 'collections' of https://github.com/raphjaph/ord into co…

df32f27

…llections

refactoring

edd0a76

Update src/inscription.rs

044d6de

Ignore malformed inscriptions. Co-authored-by: Clarke Benedict <[email protected]>

ordinally added 2 commits March 11, 2023 13:03

Fixed formatting

aaaffb6

Handle child inscription index correctly.

3ef11d0

Indirect pull from https://github.com/raphjaph/ord/pull/3/commits Props to @ericatallah for contributing this

kvnn mentioned this pull request Mar 12, 2023

Fee not calculated correctly when using parent inscription #1916

Closed

raphjaph added 3 commits March 12, 2023 17:41

rename

cb7573b

merging

9a157b4

fix inscriptionId index and remove unused file

b05c15f

clrke reviewed Mar 15, 2023

View reviewed changes

raphjaph added 2 commits March 22, 2023 13:41

finally

fbc4cde

cleanup and works

0d362e4

raphjaph force-pushed the collections branch from 79e8dbd to 0d362e4 Compare March 22, 2023 21:23

nammaki mentioned this pull request Mar 25, 2023

Inscription graffiti #884

Closed

raphjaph closed this Apr 13, 2023

raphjaph deleted the collections branch January 31, 2024 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable collections/provenance through parent inscriptions method #1869

Enable collections/provenance through parent inscriptions method #1869

raphjaph commented Mar 4, 2023

veryordinally commented Mar 8, 2023

wagmiwiz Mar 9, 2023

veryordinally commented Mar 10, 2023

ericatallah Mar 10, 2023

ericatallah Mar 10, 2023

veryordinally Mar 11, 2023

felipelincoln Mar 10, 2023

ericatallah commented Mar 11, 2023

veryordinally commented Mar 11, 2023

clrke Mar 15, 2023

clrke Mar 15, 2023

raphjaph commented Apr 13, 2023

	parent: Option<String>,
	#[allow(dead_code)]
	parent: Option<String>,

Enable collections/provenance through parent inscriptions method #1869

Enable collections/provenance through parent inscriptions method #1869

Conversation

raphjaph commented Mar 4, 2023

veryordinally commented Mar 8, 2023

wagmiwiz Mar 9, 2023

Choose a reason for hiding this comment

veryordinally commented Mar 10, 2023

ericatallah Mar 10, 2023

Choose a reason for hiding this comment

ericatallah Mar 10, 2023

Choose a reason for hiding this comment

veryordinally Mar 11, 2023

Choose a reason for hiding this comment

felipelincoln Mar 10, 2023

Choose a reason for hiding this comment

ericatallah commented Mar 11, 2023

veryordinally commented Mar 11, 2023

clrke Mar 15, 2023

Choose a reason for hiding this comment

clrke Mar 15, 2023

Choose a reason for hiding this comment

raphjaph commented Apr 13, 2023