-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redb from 0.13.0 to 1.0.2 #2141
Conversation
Converting to draft until we resolve the performance issues. |
Seeing somewhat of an improvement by setting 8 GiB cache like this:
Benchmarks in cberner/redb#603 |
See also #2183 |
I updated to 1.0.1. It's the second stable release for redb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- parameter for cache with 8GiB default as you already mentioned
- should think through which inscription to return for sat - currently not defined I think, would be better to use ordering IMO
Waiting for cberner/redb#626 to resolve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Still have to run some benchmarks.