Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redb from 0.13.0 to 1.0.2 #2141

Merged
merged 8 commits into from
Jun 29, 2023
Merged

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Jun 2, 2023

Still have to run some benchmarks.

@raphjaph raphjaph requested a review from casey June 2, 2023 10:19
@veryordinally
Copy link
Collaborator

Converting to draft until we resolve the performance issues.

@veryordinally
Copy link
Collaborator

Seeing somewhat of an improvement by setting 8 GiB cache like this:

        let database = Database::builder()
        .set_cache_size(8589934592)
        .create(&path)
        .unwrap();

Benchmarks in cberner/redb#603

@veryordinally
Copy link
Collaborator

See also #2183

@raphjaph raphjaph changed the title Update redb from 0.13.0 to 0.20.0 Update redb from 0.13.0 to 1.0.1 Jun 27, 2023
@raphjaph
Copy link
Collaborator Author

I updated to 1.0.1. It's the second stable release for redb

@raphjaph raphjaph marked this pull request as ready for review June 27, 2023 21:23
Copy link
Collaborator

@veryordinally veryordinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • parameter for cache with 8GiB default as you already mentioned
  • should think through which inscription to return for sat - currently not defined I think, would be better to use ordering IMO

src/index.rs Outdated Show resolved Hide resolved
src/index.rs Show resolved Hide resolved
src/index.rs Outdated Show resolved Hide resolved
@raphjaph
Copy link
Collaborator Author

Waiting for cberner/redb#626 to resolve.

This was referenced Jun 28, 2023
@raphjaph raphjaph changed the title Update redb from 0.13.0 to 1.0.1 Update redb from 0.13.0 to 1.0.2 Jun 29, 2023
Copy link
Collaborator

@veryordinally veryordinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphjaph raphjaph enabled auto-merge (squash) June 29, 2023 19:29
@raphjaph raphjaph merged commit 402d632 into ordinals:master Jun 29, 2023
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants