Make retrieving inscriptions in block fast #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 16, 2023 11:24
…on for first inscription block height in the test RPC server.
Fix test - when we make inscriptions in integration tests below the default block for first_inscription_height, we need to specify the correct height to the server. Gracefully handle the case where first_inscription_height is set too high - the index will now work correctly (albeit a little slower) by using saturating_sub, essentially bucketing all blocks with inscriptions below first_inscription_height into the first block.
veryordinally
changed the title
raphjaph
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing first part of #2329 - performance improvements to
get_inscriptions_in_blockby introducing an in-memory index.