-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/brotlimagick #2589
Features/brotlimagick #2589
Conversation
|
Gm @devords ! The previous few attempts were for brotli given the challenges made here And also in previous tickets there was feedback from others to make it default to brotli where appropriate. The browser doesn't need to decode in this instance as the ord server does. I can add gzip compression as well that's not a terribly complicated adjustment from here, but I would benefit more personally from brotli as it applies better to the case of text compression whereas I'm doing work to incentivize immortalized web2 data on the BTC chain. Gzip I'm happy to do in a 2nd pr, as well as adding the cli optionality for users. |
If brotli is supported everywhere, it'd make sense to start with just that. Still think it should be opt-in. Inscriptions that require content encoding header will break on all the previous versions of ord, which maynot always be desirable. |
I think they plan to do compression on everything and then decode it at the server level to be uncompressed in the content route. |
@elocremarc Just setting the |
Just noticed that the PR has the server serving decompressed content. IMO, the server should to be serving compressed content with the appropriate This approach would provide a pretty significant speed/performance boost as well. |
Closing in favor of #1713. |
http://localhost/preview/b882ff711cfb777e491d89aa13effe51a45f952189df85e2db821c1746677289i0 (testnet)