Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inscriptions module pub #3042

Closed
wants to merge 4 commits into from

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Jan 24, 2024

Made the inscriptions module and some structs pub. Did it in a pretty haphazard way and would love feedback if I should use pub use in src/inscriptions.rs so that there is less indirection (less submodules to include in the import statements). Basically any feedback on good crate/library design.

Let me know if this is useful to you guys @rot13maxi @JeremyRubin

@JeremyRubin
Copy link
Contributor

I think you should split out things into a couple different crates -- inscription for example should be really "tiny" to make it includable in Miniscript as an optional dep.

@raphjaph
Copy link
Collaborator Author

Ok thanks for the feedback! I think splitting out into crates makes sense but probably a bit too much work for the next release.

Possible sub crates:

  • ordinals/sats
  • inscriptions
  • runes
  • wallet
  • ord (binary crate)

@raphjaph raphjaph mentioned this pull request Jan 24, 2024
@casey
Copy link
Collaborator

casey commented Jan 24, 2024

What functionality would a crate need to expose for use in miniscript in order to be useful?

@JeremyRubin
Copy link
Contributor

i doubt mainline miniscript will

  1. take a non-rust-bitcoin-owned dep
  2. add inscriptions to the spec, as I've done in Sapio

That said, were you to get buy in, the functionality is basically just what's in the inscription module, which is pretty minimal.

@raphjaph raphjaph closed this Jan 31, 2024
@raphjaph raphjaph deleted the make-inscriptions-public branch January 31, 2024 18:51
@raphjaph raphjaph restored the make-inscriptions-public branch January 31, 2024 18:51
@raphjaph raphjaph reopened this Jan 31, 2024
@raphjaph
Copy link
Collaborator Author

I'm going to close this since we are working on #3079 and #1249.

@raphjaph raphjaph closed this Feb 12, 2024
@raphjaph raphjaph deleted the make-inscriptions-public branch February 15, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants