-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inscriptions module pub #3042
Conversation
I think you should split out things into a couple different crates -- inscription for example should be really "tiny" to make it includable in Miniscript as an optional dep. |
Ok thanks for the feedback! I think splitting out into crates makes sense but probably a bit too much work for the next release. Possible sub crates:
|
What functionality would a crate need to expose for use in miniscript in order to be useful? |
i doubt mainline miniscript will
That said, were you to get buy in, the functionality is basically just what's in the inscription module, which is pretty minimal. |
Made the
inscriptions
module and some structspub
. Did it in a pretty haphazard way and would love feedback if I should usepub use
insrc/inscriptions.rs
so that there is less indirection (less submodules to include in the import statements). Basically any feedback on good crate/library design.Let me know if this is useful to you guys @rot13maxi @JeremyRubin