Use redb's two-phase write strategy in production #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I benchmarked redb's two write strategies, checksum, which uses a checksum to recover the database in case of a crash, and two-phase, which guarantees that the header on disk does not need to be recovered in case of a crash, but which requires an additional fsync per commit.
Two-phase narrowly beat out checksum, completing in 27 hours vs 28 hours. This is likely because sync time is dominated by very large commits, where checksum calculation is more costly than an additional commit. I left the tests using the checksum write strategy, because it's faster in tests, at 5 seconds vs 4 seconds for the two-phase commit.
@cberner Nothing too surprising here, although I thought you'd be interested anyways.