Make index faster by faster checking for uncommon or more rare ordinals #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cient call. This method call contributed for 70% of the time in index_transaction, so it's worth the more verbose, less general method. There's more potential here, as self.epoch() can likely be sped up significantly - the binary search takes an inordinate amount of time still.
|
I tried to do this separate from #703 but am also Github challenged. |
popcnt1
pushed a commit
to popcnt1/ord
that referenced
this pull request
Jan 11, 2025
Replace check for uncommon or better rarity by specialized, more efficient call. This method call contributed for 70% of the time in index_transaction, so it's worth adding a more specialized method. There's more potential here, as self.epoch() can likely be sped up significantly - the binary search still takes an inordinate amount of time. See issue ordinals#711.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #371 starting with a trivial improvement:
Replace check for uncommon or better rarity by specialized, more efficient method. This line in index_transaction accounted 70% of the time in index_transaction, so it's worth the more verbose, less general method.
There's more potential here, as self.epoch() can likely be sped up significantly - the binary search takes an inordinate amount of time still.