Improve ping script output readability #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpdx
reviewed
Oct 8, 2024
Previously each ping iteration could print up to three lines, and it was sometimes easy to miss if the latest iteration succeeded or failed. This tries to limit each iteration to only a single vertically aligned line, printing information as it comes in. While I was here I simplified the implementation: - By being a little more careful about where and how long blocking happens I was able to drop multiple threads. This makes coordinating printing lines and shared data much easier - Removed previous loop timestamp tracking, it didn't seem to work anyway?
ThirteenFish
force-pushed
the
ping-output
branch
from
ac2696d to
aa64c7d
Compare
Adds back the capability to handle ping responses that are batched (for example try to a local c3 with the argument -l 25), and also some amount of handling for stranger anomalous conditions. Display has been now separated out from the logic, class Link handles the meaty bits and ping_loop() runs the top level loop and displays the output. Output has been enhanced with unicode and the ability to handle batched received packets. Adds a --count argument to stop after attempting to send count pings
ThirteenFish
force-pushed
the
ping-output
branch
from
5c5fcda to
756753d
Compare
ryanpdx
approved these changes
Oct 26, 2024
scripts/edl_ping_loop.py
Outdated
| self.echo = 0 | ||
| self.seqn = seqn | ||
| self.hmac = hmac | ||
| self.stim: OrderedDict[int, float] = OrderedDict() |
There was a problem hiding this comment.
Could use a longer name than stim for readability
scripts/edl_ping_loop.py
Outdated
|
|
||
| self.sent = 0 | ||
| self.echo = 0 | ||
| self.seqn = seqn |
There was a problem hiding this comment.
I would change this to seq_num or sequence_number for readability
Also fixed spacing on the column header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously each ping iteration could print up to three lines, and it was sometimes easy to miss if the latest iteration succeeded or failed. This tries to limit each iteration to only a single vertically aligned line, printing information as it comes in.
While I was here I simplified the implementation: