👀 VISION DISABILITY — Suggesition: Remove one shade of gray from the PR code-reviewing screen

[Zernach]

Accessibility: PR Reviewing Background Colors for Code Blocks

❌ Here's the current implementation:

✅ And here's the suggested change:

✨ Description

• Instead of two shades of gray, eliminate the light gray color altogether, in favor of using only the dark gray.
• The current implementation is difficult to read/comprehend.
• With too many different shades of background colors with the current implementation, there's less flow for me to freely read.
• As a user, I don't need to know which parts of someone's unedited code I've previously expanded compared to which parts were unedited and naturally-visible when I first landed on the review page.

[ghostinhershell]

Hi @Zernach,

Thanks so much for reaching out and including as much information as you did. I've submitted this feedback over to the Accessibility team so it's now on their radar. If you have any additional comments or feedback that you'd like to share, please feel free to do so here and I can pass that along as well.

Thanks!

[easontm]

Because the light grey text can't be re-collapsed (without a page reload), IMO it's completely non-functional. After expansion all it does is visually highlight lines that are farther from lines which have been edited (which I can already tell because they're physically farther from the red/green lines). If I'm rapidly scrolling through a long file which I expanded so I could read the context, the lighter grey makes it harder to see the contrast of the lines that I'm trying to find again, i.e. red/green.

[Zernach]

Thank you, @easontm for describing the problems that we're experiencing and commenting on this thread. I agree with everything you wrote!

[mobileapp-max]

+1 on this... there is an unnecessary number of shades-of-gray background colors when reviewing code changes. Please help us read the GitHub website better :)

[cehfisher]

Hi @Zernach, thank you for sharing your feedback! We wanted to follow up on the bug you reported.

After consulting with the GitHub accessibility team regarding your question, they recommended trying the high contrast theme to address your color contrast needs. Does this theme help resolve the issue you encountered?