Distributed support not working on new server join

[fridaystreet]

Hi,

This fix (#111) appeared to add support for distributed servers, but only seems to address it when the connection is created. When further configuration change update messages are received for servers being added to the cluster it causes an exception as per below.

config is undefined

node_modules/orientjs/lib/transport/binary/index.js:91
var servers = config.members.filter(function (m) {
^

TypeError: Cannot read property 'filter' of undefined
at bindServers (/home/paul/dev/ember2-frontend/sane/data/ec/server/node_modules/sails-orientdb/node_modules/orientjs/lib/transport/binary/index.js:91:31)
at BinaryTransport. (/home/paul/dev/ember2-frontend/sane/data/ec/server/node_modules/sails-orientdb/node_modules/orientjs/lib/transport/binary/index.js:129:20)
at emitOne (events.js:96:13)
at Connection.emit (events.js:188:7)
at Connection.process (/home/paul/dev/ember2-frontend/sane/data/ec/server/node_modules/sails-orientdb/node_modules/orientjs/lib/transport/binary/connection.js:384:12)
at Connection.handleSocketData (/home/paul/dev/ember2-frontend/sane/data/ec/server/node_modules/sails-orientdb/node_modules/orientjs/lib/transport/binary/connection.js:289:20)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:177:18)
at Socket.Readable.push (_stream_readable.js:135:10)
at TCP.onread (net.js:542:20)

Tracing it back to the Operation.prototype.consume function (line 361) in protocol33/operation.js

The function doesn't seem to handle the message type 80 and sends through an empty dictionary. Well it would do, but there seems to be a bug in line 432 which is trying to return the obj.data key which doesn't exist.

429 offset += 5; // ignore the next integer
430 obj = {};
431 offset += this.parsePushedData(buffer, offset, obj, 'data');
432 return [Operation.PUSH_DATA, offset, obj.data];

Any ideas how to get this working?

Cheers
Paul

[wolf4ood]

Hi @fridaystreet which version of OrientDB?

[fridaystreet]

Hi Enrico,

I've tried lots of versions, but for arguments sake let's say 2.2.2

Cheers
Paul

On 22 Jul 2016 5:00 PM, "Enrico Risa" [email protected] wrote:

Hi @fridaystreet https://github.com/fridaystreet which version of
OrientDB?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#191 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFxnyzJlZYOhSgNBQSSSNRLATCosufyRks5qYIaJgaJpZM4JSfXJ
.

[wolf4ood]

hi @fridaystreet

seems that the fix has not been ported well in 2.2.x version.
I will fix it for the next release.

Thanks

[fridaystreet]

No worries much appreciated

On Mon, Jul 25, 2016 at 3:46 PM, Enrico Risa [email protected]
wrote:

hi @fridaystreet https://github.com/fridaystreet

seems that the fix has not been ported well in 2.2.x version.
I will fix it for the next release.

Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#191 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFxny0SH2YJ0tlKMs3XiILPUP1rLpXGmks5qZGm8gaJpZM4JSfXJ
.

[wolf4ood]

hi @fridaystreet fixed in 2.2.2

thanks

[fridaystreet]

Awesome thanks

On Mon, Aug 1, 2016 at 9:55 PM, Enrico Risa [email protected]
wrote:

hi @fridaystreet https://github.com/fridaystreet fixed in 2.2.2

thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#191 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFxny3aMPkQnwxV5UDHpYmFApyVhuJG8ks5qbfrbgaJpZM4JSfXJ
.