Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript]: Changes for typescript definition + add new typescript definition and embed it to orientjs package . #438

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

saeedtabrizi
Copy link
Contributor

based on #184 (comment) i just a fix for it.
Thanks @diegonc
@wolf4ood, @lvca

update saeed tabrizi email address .
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 80.574% when pulling 283b6e0 on saeedtabrizi:develop into cdd4572 on orientechnologies:develop.

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage decreased (-0.01%) to 80.68% when pulling b6e3405 on saeedtabrizi:develop into cdd4572 on orientechnologies:develop.

@saeedtabrizi saeedtabrizi changed the title Changes for typescript definition [Typescript]: Changes for typescript definition + add new typescript definition and embed it to orientjs package . Sep 18, 2020
@diegonc
Copy link

diegonc commented Sep 18, 2020

Hi @saeedtabrizi. Where should I direct further feature requests for typings?

I'm referring particularly to the possibility of using a function in the let call documented at this test.

type OFnStatement = (s: OStatement) => OStatement;

interface OStatement extends OQuery<any> {
  ...
  let(name: string, value: string | OStatement | OFnStatement): OStatement;
}

class ODB extends events.EventEmitter {
  ...
  let(name: string, value: string | OStatement | OFnStatement): OStatement;
}

@saeedtabrizi
Copy link
Contributor Author

saeedtabrizi commented Sep 18, 2020

@diegonc unfortunately the https://github.com/saeedtabrizi/DefinitelyTyped/orientjs deployment process is very slow , so I decided to continue here (in master project) .
Welcome to all orientjs typings task in here .
About the requested feature please write an issue with starting by [Typescript] in title .
I will check and implement it asap .
Many thanks .

@saeedtabrizi
Copy link
Contributor Author

@diegonc , good news that we have the new feature that you requested only last hour .
please write each feature or epic in a seprated issue by starting [Typescript] title .
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants