Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support i18n #284

Merged
merged 9 commits into from
Sep 4, 2023
Merged

feat: support i18n #284

merged 9 commits into from
Sep 4, 2023

Conversation

zepatrik
Copy link
Member

No description provided.

# Conflicts:
#	package-lock.json
#	package.json
#	src/index.ts
#	src/routes/login.ts
#	src/routes/recovery.ts
#	src/routes/verification.ts
#	views/layouts/auth.hbs
#	views/login.hbs
#	views/registration.hbs
#	views/settings.hbs
@zepatrik zepatrik marked this pull request as ready for review September 1, 2023 13:37
@zepatrik
Copy link
Member Author

zepatrik commented Sep 1, 2023

I went though all screens manually on the local hostedui setup and it works as expected.

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very solid, just a few nits and it should be good to go :)

src/routes/consent.ts Outdated Show resolved Hide resolved
src/routes/consent.ts Outdated Show resolved Hide resolved
views/layouts/settings.hbs Outdated Show resolved Hide resolved
views/partials/webauthn_setup.hbs Outdated Show resolved Hide resolved
@zepatrik zepatrik requested a review from Benehiko September 4, 2023 09:51
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Benehiko
Copy link
Contributor

Benehiko commented Sep 4, 2023

Did you want to wait for ory/elements#135?

@zepatrik
Copy link
Member Author

zepatrik commented Sep 4, 2023

Yeah let's wait for that fix.

@zepatrik zepatrik merged commit 47ad34b into master Sep 4, 2023
4 of 5 checks passed
@zepatrik zepatrik deleted the feat/i18n branch September 4, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants