Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conventional commits fails with false negative #158

Closed
aeneasr opened this issue Jul 16, 2022 · 3 comments
Closed

Conventional commits fails with false negative #158

aeneasr opened this issue Jul 16, 2022 · 3 comments

Comments

@aeneasr
Copy link
Member

aeneasr commented Jul 16, 2022

This PR has the correct title ory/kratos#2593 but the CI failed for conventional commits. Can you PTAL @kevgo ? TY!
@vinckr
Copy link
Member

vinckr commented Jul 18, 2022

i think its because sdk is not part of the scopes

          scopes: |
            blog
            cms
            deps
            docs
            home
            hydra
            keto
            kratos
            stats

@kevgo
Copy link
Contributor

kevgo commented Jul 18, 2022

Yes, a few scopes are missing: sdk, console, backoffice. This is the type of feedback we need to fine-tune this action. @zepatrik has already sent a PR to upstream: amannn/action-semantic-pull-request#193

@kevgo kevgo mentioned this issue Jul 18, 2022
Closed
@kevgo
Copy link
Contributor

kevgo commented Aug 13, 2022

This is fixed now and can be closed.

@aeneasr aeneasr closed this as completed Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevgo @aeneasr @vinckr