Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sdk): identifier is actually required #2593

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 15, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner July 15, 2022 17:46
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #2593 (05361e9) into master (f43396b) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2593      +/-   ##
==========================================
+ Coverage   75.14%   75.21%   +0.06%     
==========================================
  Files         295      295              
  Lines       16361    16361              
==========================================
+ Hits        12295    12306      +11     
+ Misses       3127     3117      -10     
+ Partials      939      938       -1     
Impacted Files Coverage Δ
selfservice/strategy/webauthn/login.go 62.50% <ø> (ø)
session/test/persistence.go 100.00% <0.00%> (+1.38%) ⬆️
cmd/courier/watch.go 76.27% <0.00%> (+11.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f2618...05361e9. Read the comment docs.

@aeneasr aeneasr merged commit f89d279 into master Jul 16, 2022
@aeneasr aeneasr deleted the update-identifier-webauthn-docs branch July 16, 2022 08:20
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant