You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
According to the Oathkeeper documentation the "jwt" authenticator can fetch the token from either a named HTTP header or from the query parameter. At the same time, "oauth2_introspection" authenticator supports the named cookie as source. It would be great to support the cookie source for "jwt" authenticator as well.
Describe the solution you'd like
I may be wrong but it looks like it may be already supported, authenticator_jwt.go calls helper.BearerTokenFromRequest() to get the token and this function does support all 3 sources. Is it possible that this is just a missed point in the documentation?
Thanks!
The text was updated successfully, but these errors were encountered:
I am trying to add the unit tests for this + update the schema. Turns out, both authenticator_oauth2_introspection_test.go and authenticator_jwt_test.go are missing the tests for the cookie case and the schema for the "jwt" authenticator is missing this oneof element too. Will provider a PR soon.
ngrigoriev
added a commit
to ngrigoriev/oathkeeper
that referenced
this issue
Jan 7, 2020
… oauth2_introspection authenticators (ory#330)
Update the schemas to add missing cookie config element
Signed-off-by: Grigoriev, Nikolai <[email protected]>
Is your feature request related to a problem? Please describe.
According to the Oathkeeper documentation the "jwt" authenticator can fetch the token from either a named HTTP header or from the query parameter. At the same time, "oauth2_introspection" authenticator supports the named cookie as source. It would be great to support the cookie source for "jwt" authenticator as well.
Describe the solution you'd like
I may be wrong but it looks like it may be already supported, authenticator_jwt.go calls helper.BearerTokenFromRequest() to get the token and this function does support all 3 sources. Is it possible that this is just a missed point in the documentation?
Thanks!
The text was updated successfully, but these errors were encountered: