Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove submodule nist-source #1809

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

degenaro
Copy link
Collaborator

@degenaro degenaro commented Feb 7, 2025

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro degenaro requested a review from a team as a code owner February 7, 2025 13:48
@degenaro degenaro added this to the v3.8.0 milestone Feb 7, 2025
@degenaro degenaro changed the title fix: Remove submodule nist source fix: remove submodule nist-source Feb 7, 2025
@degenaro degenaro self-assigned this Feb 7, 2025
Copy link
Member

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro degenaro requested a review from a team February 10, 2025 14:29
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro degenaro merged commit 0d65f59 into develop Feb 11, 2025
14 checks passed
@degenaro degenaro deleted the remove-submodule-nist-source branch February 11, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants