Rename is_hermitian_matrix to is_hermitian
#2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/is_hermitian
branch
from
f7e3e45 to
3f978c8
Compare
|
The nightly failure seems to be #2543. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2556 +/- ##
==========================================
+ Coverage 72.82% 72.88% +0.05%
==========================================
Files 415 415
Lines 55641 55837 +196
==========================================
+ Hits 40520 40696 +176
- Misses 15121 15141 +20
|
thofma
approved these changes
Jul 14, 2023
fingolfin
approved these changes
Jul 14, 2023
fingolfin
reviewed
Jul 14, 2023
| @@ -86,7 +86,7 @@ end | |||
| x=matrix(F,4,4,[1,z,0,0,0,1,z^2,z,z,0,0,1,0,0,z+1,0]) | |||
| y=x+transpose(x) | |||
| @test is_symmetric(y) | |||
| @test is_hermitian_matrix(x+conjugate_transpose(x)) | |||
| @test is_hermitian(x+conjugate_transpose(x)) | |||
| @test is_skewsymmetric_matrix(y) | |||
There was a problem hiding this comment.
I am fine with this change, but then perhaps we should also do the same for is_skewsymmetric ?
There was a problem hiding this comment.
Please see #2555 for this.
There are two semantically different implementations that would be merged by renaming is_skewsymmetric_matrix.
|
The errors on nightly and 1.10-alpha1 are not due to changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_hermitianalready exists for other types and is more streamlined with similar function names, e.g.is_symmetric.