-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Kotlin 1.5 #175
Bump to Kotlin 1.5 #175
Conversation
Hey @oshai you seem like the main contributer here. Let me know if I should do anything in particular, in terms of workflow or checks! I wasn't sure: should I manually bump the version from |
Any news on this or #177? Can I help with either? |
I managed to get some progress on #177 . It looks like both jcenter was removed and travis project needs migration to |
ok, I been able to release with #177 , if you can rebase this PR I will merge it. |
Kotlin 1.5 is out, but kotlin-logging still being on 1.4 causes dependency conflicts in my project. With this change, I bump the Kotlin version to 1.5. https://blog.jetbrains.com/kotlin/2021/05/kotlin-1-5-0-released/
Rebased. Exciting! Is my understanding correct that you bump versions in a separate commit? |
I will bump the version once merged. Right now the build fails with the following error:
Can you please take a look? |
Oh damn - will try to reproduce this failure locally and fix, yes! |
Thanks for the PR, I changed to latest version 1.5.21 and the build passed. Also upgraded dokka and change api level to 1.4 - in order to support using older kotlin version by lib users. |
* Bump to Kotlin 1.5 Kotlin 1.5 is out, but kotlin-logging still being on 1.4 causes dependency conflicts in my project. With this change, I bump the Kotlin version to 1.5. https://blog.jetbrains.com/kotlin/2021/05/kotlin-1-5-0-released/ * Update build.gradle.kts Co-authored-by: Julien Lehuen <[email protected]> Co-authored-by: Ohad Shai <[email protected]>
Awesome - thank you so much for following up, I'm sorry I didn't get to it myself on time! |
Kotlin 1.5 is out, but kotlin-logging still being on 1.4 causes dependency conflicts in my project. With this change, I bump the Kotlin version to 1.5.
https://blog.jetbrains.com/kotlin/2021/05/kotlin-1-5-0-released/