build(deps): bump log4j from 2.18.0 to 2.19.0 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yeikel - would you like to take a look at the failing tests? |
I believe that this is blocked until log4j adds support for this |
sishbi
reviewed
Sep 11, 2022
versions.gradle.kts
Outdated
| extra["slf4j_version"] = "1.7.32" | ||
| extra["log4j_version"] = "2.18.0" | ||
| extra["slf4j_version"] = "2.0.0" | ||
| extra["log4j_version"] = "2.18.1-SNAPSHOT" |
There was a problem hiding this comment.
Can I suggest you move back to using Log4J 2.18.0 (instead of the snapshot) and change the log4j-slf4j-impl dependency to log4j-slf4j18-impl then it should work 😄
See here for info on the new implementation: https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/index.html
log4j-slf4j18-impl should be used with SLF4J 1.8.x releases or newer.
Note: log4j-slf4j18-impl has a dependency on SLF4J 1.8-beta4 - I don't know why log4j haven't updated the dependency to 2.0.0 yet.
There was a problem hiding this comment.
Correction, log4j are in the process of upgrading to slf4j 2.x and will introduce log4j-slf4j2-impl in 2.19.0 which will depend on SLF4J 2.0.0 and will fully implement the interface
So this PR will have to wait until that happens, sorry for the confusion...
There was a problem hiding this comment.
Apologies for the confusion. I tried 2.18.1-SNAPSHOT to see if the snapshot would work(against the CI) but I'll put it back to a non-snapshot version as soon as we hear back from log4j
There was a problem hiding this comment.
Thanks, I think the Log4J SLF4J2 support is handled by this ticket in log4j: https://issues.apache.org/jira/browse/LOG4J2-3370 which is targeted at 2.19.0 - still no ETA on a 2.19.0 release though
yeikel
changed the title
yeikel
changed the title
- Bumps log4j from 2.18.0 to 2.19.0 - Bumps slf4j from 1.7.32 to 2.0.1
|
@shai It should be ready to go now |
|
Thanks! |
|
I think I am going to bump the version to 3.x for kotlin-logging to reflect the major upgrade of slf4j. |
That sounds reasonable. Thank you! |
kyhule
referenced
this pull request
in kyhule/polyworld-external-catalog
Jun 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.microutils:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `2.1.23` -> `3.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oshai/kotlin-logging</summary> ### [`v3.0.5`](https://togithub.com/oshai/kotlin-logging/releases/tag/3.0.5) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/3.0.4...3.0.5) #### What's Changed - build(deps): bump kotlin multiplatform from 1.7.20 to 1.7.21 by [@​yeikel](https://togithub.com/yeikel) in [https://github.com/oshai/kotlin-logging/pull/261](https://togithub.com/oshai/kotlin-logging/pull/261) - upgrade kotlin to 1.8.0 by [@​oshai](https://togithub.com/oshai) in [https://github.com/oshai/kotlin-logging/pull/267](https://togithub.com/oshai/kotlin-logging/pull/267) - update links by [@​oshai](https://togithub.com/oshai) in [https://github.com/oshai/kotlin-logging/pull/268](https://togithub.com/oshai/kotlin-logging/pull/268) **Full Changelog**: oshai/kotlin-logging@3.0.4...3.0.5 ### [`v3.0.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/3.0.4) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/3.0.3...3.0.4) #### What's Changed - set jvmTarget back to 8 by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/258](https://togithub.com/MicroUtils/kotlin-logging/pull/258) - add ktfmtCheck to CI by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/259](https://togithub.com/MicroUtils/kotlin-logging/pull/259) **Full Changelog**: oshai/kotlin-logging@3.0.3...3.0.4 ### [`v3.0.3`](https://togithub.com/oshai/kotlin-logging/releases/tag/3.0.3) #### What's Changed - add "Automatic-Module-Name" for [#​223](https://togithub.com/oshai/kotlin-logging/issues/223) by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/256](https://togithub.com/MicroUtils/kotlin-logging/pull/256) - reword slf4j usage for [#​229](https://togithub.com/oshai/kotlin-logging/issues/229) by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/255](https://togithub.com/MicroUtils/kotlin-logging/pull/255) - add simple native test (main) by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/219](https://togithub.com/MicroUtils/kotlin-logging/pull/219) **Full Changelog**: oshai/kotlin-logging@3.0.1...3.0.3 ### [`v3.0.0`](https://togithub.com/oshai/kotlin-logging/releases/tag/3.0.0) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/2.1.23...3.0.0) #### What's Changed **Major version upgrade to 3.0.0 to reflect upgrade of slf4j to 2.x.** - Upgrade slf4j 1.x->2.x by [@​yeikel](https://togithub.com/yeikel) in [https://github.com/MicroUtils/kotlin-logging/pull/234](https://togithub.com/MicroUtils/kotlin-logging/pull/234) - fix kdoc of mu.KotlinLogging.logger by [@​aivantsov](https://togithub.com/aivantsov) in [https://github.com/MicroUtils/kotlin-logging/pull/230](https://togithub.com/MicroUtils/kotlin-logging/pull/230) - remove 1.x links from readme by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/231](https://togithub.com/MicroUtils/kotlin-logging/pull/231) - build(deps): bump log4j from 2.17.1 to 2.18.0 by [@​yeikel](https://togithub.com/yeikel) in [https://github.com/MicroUtils/kotlin-logging/pull/235](https://togithub.com/MicroUtils/kotlin-logging/pull/235) - Create SECURITY.md by [@​oshai](https://togithub.com/oshai) in [https://github.com/MicroUtils/kotlin-logging/pull/237](https://togithub.com/MicroUtils/kotlin-logging/pull/237) - Bump gradle wrapper to 7.5.1 by [@​yeikel](https://togithub.com/yeikel) in [https://github.com/MicroUtils/kotlin-logging/pull/238](https://togithub.com/MicroUtils/kotlin-logging/pull/238) #### New Contributors - [@​aivantsov](https://togithub.com/aivantsov) made their first contribution in [https://github.com/MicroUtils/kotlin-logging/pull/230](https://togithub.com/MicroUtils/kotlin-logging/pull/230) - [@​yeikel](https://togithub.com/yeikel) made their first contribution in [https://github.com/MicroUtils/kotlin-logging/pull/235](https://togithub.com/MicroUtils/kotlin-logging/pull/235) **Full Changelog**: oshai/kotlin-logging@2.1.23...3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/kyhule/polyworld-external-catalog). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump log4j from 2.18.0 to 2.19.0
log4j-slf4j2. See https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/index.htmlRelease notes:
log4j : https://logging.apache.org/log4j/2.x/changes-report.html#a2.19.0
slf4j : https://www.slf4j.org/faq.html#changesInVersion200