Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoder uses layout for all message formating, but still prevents bla… #102

Merged

Conversation

fupgang
Copy link
Contributor

@fupgang fupgang commented Mar 11, 2024

Fixes #100

Formatting the message itself (including shortening, trimming, etc.) should be the sole responsibility of the pattern layout. Only the blank string handling has to be addresses – as you pointed out.

API-Breaks:

  • removed maxShortMessageLength from GelfEncoder, has to be configured by the user with a suitable Layout
  • renamed shortPatternLayout to shortMessageLayout
  • renamed fullPatternLayout to fullMessageLayout

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (1259b4a) to head (8a3ac4f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     85.81%   86.47%   +0.66%     
+ Complexity      255      250       -5     
============================================
  Files            27       27              
  Lines           698      673      -25     
  Branches         72       67       -5     
============================================
- Hits            599      582      -17     
+ Misses           75       70       -5     
+ Partials         24       21       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osiegmar osiegmar merged commit 372c9a7 into osiegmar:master Mar 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All newlines in short messages are replaced with whitespaces
2 participants