Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13 #1047

Merged
merged 59 commits into from
Dec 8, 2022
Merged

V13 #1047

merged 59 commits into from
Dec 8, 2022

Conversation

jonator
Copy link
Member

@jonator jonator commented Nov 23, 2022

Testing

  • Joining pool with multiple assets
  • Swapping through weighted pool
  • Swapping through stableswap pool (perhaps slippage setting needs to be higher)
  • Multihop swap through OSMO pools, with fee discount (ION->FOO on swap page)
  • Creating pool

jonator and others added 30 commits November 13, 2022 12:37
…1022)

* initial bigdec

* (fails) new solver math

* implement bigdec and its conversion functions

* fix solver math and fix tests

* convert internal math to use BigDec

* remove unnecessary exports
@arispech
Copy link

arispech commented Nov 29, 2022

  • Joining pool with multiple assets
  • Removing liquidity from pool
  • Swapping through weighted pool
  • Multihop swap through OSMO pools, with fee discount (ION->FOO on swap page)
    • ⚠️ Issue: FOO not available, not sure how to replicate multihop.
  • Creating pool
  • Creating stable pool
  • Swapping through stableswap pool (perhaps slippage setting needs to be higher)

@delivan
Copy link
Member

delivan commented Nov 29, 2022

@jonator typescript can generate .d.ts file automatically when build .ts file. In tsconfig.json, remove "declarationDir": "./types" and build. Then .d.ts files are going to be generated. So I think we don't need to manage .d.ts manually.

@jonator
Copy link
Member Author

jonator commented Nov 29, 2022

@arispech

Multihop swap through OSMO pools, with fee discount (ION->FOO on swap page)

  • ⚠️ Issue: FOO not available, not sure how to replicate multihop.

We should be able to use the create pool UI to create pools with IBC tokens that don't have an OSMO pair yet, and use that to test fee discount.

For multihop through stableswap pools, we can also use the create pool UI to create (low liquidity) stableswap pools for pairs that don't exist yet, then we can make sure they're included in the swap router (send me DM when pools are created).

Also, I've done brief testing on the OSMO swap fee discount, as well as multihop through stableswap pools, as well as swapping through individual pools. Did not run into issues (aside from slippage setting issues since the created pools were low liquidity).

@jonator
Copy link
Member Author

jonator commented Nov 29, 2022

@jonator typescript can generate .d.ts file automatically when build .ts file. In tsconfig.json, remove "declarationDir": "./types"and build. Then.d.tsfiles are going to be generated. So I think we don't need to manage.d.ts` manually.

Yeah I talked to dan and it seems the tradeoff is by publishing type files in packages, type defs are immediately available to the IDE after running yarn install, otherwise, yarn build needs to run first for language servers in IDEs to get type definitions. I agree though, this isn't worth it for complicated our fe devs committing process, and making PRs bigger. I'll remove types folders.

@delivan delivan merged commit 29df05f into stage Dec 8, 2022
@jonator jonator deleted the jonator/v13 branch December 11, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants