Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile #938

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Add dockerfile #938

merged 1 commit into from
Oct 29, 2022

Conversation

honsontran
Copy link
Contributor

@honsontran honsontran commented Oct 28, 2022

Docker files needed for deployment of Osmosis on Flux.

@vercel
Copy link

vercel bot commented Oct 28, 2022

@honsontran is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osmosis-frontend ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 3:29AM (UTC)
osmosis-frontier ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 3:29AM (UTC)
osmosis-testnet ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 3:29AM (UTC)

@daniel-farina
Copy link
Contributor

@jonator @niccoloraspa
This PR is for docker files needed to deploy Osmosis on decentralized cloud provider Flux. I think we should probably make a folder to categorize this sort of files.

What do guys think would be a good place for it?

/services/flux
or
.github/cloudproviders/flux ?

Thanks

@niccoloraspa
Copy link
Member

niccoloraspa commented Oct 29, 2022

Thanks @honsontran for the contribution.

There are no Flux specific files in this commit so there is no need for additional folders.

The Dockerfile and the docker-compose.yaml can stay both at the root level.

Both files need to expose the environment variables used in the deployment.

@jonator
Copy link
Member

jonator commented Oct 29, 2022

I agree. Also having the Dockerfile at the root may be needed for proper function by Docker.

@jonator jonator merged commit 22c613a into osmosis-labs:master Oct 29, 2022
@honsontran
Copy link
Contributor Author

Thanks @honsontran for the contribution.

There are no Flux specific files in this commit so there is no need for additional folders.

The Dockerfile and the docker-compose.yaml can stay both at the root level.

Both files need to expose the environment variables used in the deployment.

Hi @niccoloraspa, just wanted to make sure, what environment variables are you referring to? I can make the adjustments if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants