Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Axl Network Selection #977

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Fix Axl Network Selection #977

merged 7 commits into from
Nov 15, 2022

Conversation

JeremyParish69
Copy link
Collaborator

To fix the readability of Network names in the global Deposit and Withdrawal (transfer-asset-select) modal.

Renamed SourceChain values from axelar API inputs -> a prettyName.

export type SourceChain =
  | "Aurora Testnet"
  | "Avalanche"
  | "Avalanche Fuji Testnet"
  | "Binance Smart Chain"
  | "BSC Testnet"
  | "Ethereum"
  | "Goerli Testnet"
  | "Fantom"
  | "Fantom Testnet"
  | "Moonbeam"
  | "Moonbase Alpha"
  | "Polygon"
  | "Mumbai";

There are now separate maps for axelar keys and ethereum chain IDs by SourceChain (reverse).

Added USDC transfers to/from Binance.

Frontier and Testnet environments now show a pretty Network Name in both modals, triggers Eth wallet to switch to correct network, and can detect when the correct network is selected.

Untested: whether transfers actually work.

@vercel
Copy link

vercel bot commented Nov 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osmosis-frontend ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 4:29PM (UTC)
osmosis-frontend-legacy ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 4:29PM (UTC)
osmosis-frontend-v13-chain ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 4:29PM (UTC)
osmosis-frontier ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 4:29PM (UTC)
osmosis-testnet ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 4:29PM (UTC)

Copy link
Member

@jonator jonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update from stage and fix conflicts

packages/web/integrations/axelar/types.ts Outdated Show resolved Hide resolved
packages/web/integrations/axelar/types.ts Outdated Show resolved Hide resolved
@jonator
Copy link
Member

jonator commented Nov 9, 2022

Let's include fee updates to this PR. I'll also create an issue to try to use the getTransferFee Axelar SDK API, as it wasn't working properly when I built this integration.

Thread from Axelar

@jonator
Copy link
Member

jonator commented Nov 9, 2022

FYI created this issue

#982

@JeremyParish69
Copy link
Collaborator Author

Let's include fee updates to this PR. I'll also create an issue to try to use the getTransferFee Axelar SDK API, as it wasn't working properly when I built this integration.

Thread from Axelar

Fees have been updated for all assets (mainnet and testnet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants