Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump SDK version to osmosis-main #3720

Closed
wants to merge 3 commits into from

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Dec 14, 2022

Changelog

  • Bump SDK version to osmosis-main (latest HEAD commit), which includes all the ABCI changes and Tendermint v0.37.x

TODO

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Dec 14, 2022

I think the problem is that Go is trying to download go: downloading github.com/gogo/protobuf v1.3.3 due to downstream deps (IBC & wasm) and this isn't allowing us to update proto correctly...

I think for IBC, we have to use a version that's SDK v0.46.x compatible?

cc @ValarDragon

@faddat
Copy link
Member

faddat commented Dec 17, 2022

Hi @alexanderbez , I can confirm about the protobuf issue, I faced it upstream, too.

I'm very happy to help out with either a 47 or 46 compatible osmosis. Is there any document on the intention of the changes to osmosis-main?

If the only changes to osmosis-main so far are abci++ / tendermint related, it is likely that further changes will be needed to osmosis-main to be able to support a 46 compatible or 47 ibc-go.

AFAIK, the only 47-compatible ibc-go is here:

And the 47-compatible cosmwasm code is here:

As for SDK 46, Notional has written code for wasmd support for 46:

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Dec 19, 2022

@faddat tysm for the willingness to help out. So to give you some context:

  • Osmosis SDK fork now includes TM v0.37.x on osmosis-main
  • osmosis-main is STILL based on core SDK v0.45.x semantics BUT now uses cosmos/gogo instead of gogoproto. I spent A LOT of timing getting this to work. It's essentially v0.45.x but with 0.46/0.47 Proto stuffs which is necessary.
  • In order to have this PR work and to be pinned against osmosis-main as intended, we need to ensure all downstream deps also use cosmos/gogo instead of gogoproto. AFAIK, only WASM and IBC are the deps that need to be updated. I believe there is an IBC PR that updates it to use cosmos/gogo. I cannot speak for WASM though.

@github-actions github-actions bot added the Stale label Jan 3, 2023
@alexanderbez alexanderbez removed the Stale label Jan 4, 2023
@osmosis-labs osmosis-labs deleted a comment from github-actions bot Jan 4, 2023
@alexanderbez
Copy link
Contributor Author

In the meantime, I will:

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jan 19, 2023
@github-actions github-actions bot closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants