Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put parsers in a lazy static. #20

Merged
merged 3 commits into from
May 18, 2020
Merged

Put parsers in a lazy static. #20

merged 3 commits into from
May 18, 2020

Conversation

samscott89
Copy link
Member

Speeds up debug test by ~120x (10mins -> 5s),
and release tests by ~20x (10s -> 0.5s).

samscott89 added 3 commits May 16, 2020 09:08
@samscott89
Put parsers in a lazy static.
4ed3ddc 
Speeds up debug test by ~120x (10mins -> 5s),
and release tests by ~20x (10s -> 0.5s).
@samscott89
Don't need to run release tests.
1c6d588
@samscott89
Build FFI from debug.
6d32c8d
gj
gj approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@gj gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@samscott89 samscott89 merged commit d5b9358 into master May 18, 2020
@samscott89 samscott89 deleted the sam/lazy-static-parser branch May 18, 2020 13:36
@plarsson plarsson mentioned this pull request Dec 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gj gj gj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samscott89 @gj