ScanSummary: Do not use sorted set for licenseFindings
#7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
license-findings-set
branch
from
7ef307b
to
e957db5
Compare
sschuberth
requested changes
May 16, 2023
fviernau
force-pushed
the
license-findings-set
branch
from
e957db5
to
a964529
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7004 +/- ##
============================================
- Coverage 64.30% 64.29% -0.01%
Complexity 1970 1970
============================================
Files 331 331
Lines 16692 16694 +2
Branches 2382 2382
============================================
Hits 10734 10734
- Misses 4921 4923 +2
Partials 1037 1037
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
license-findings-set
branch
from
a964529
to
cff8724
Compare
sschuberth
previously approved these changes
May 16, 2023
fviernau
force-pushed
the
license-findings-set
branch
from
cff8724
to
7a019c5
Compare
sschuberth
requested changes
May 16, 2023
plugins/reporters/evaluated-model/src/main/kotlin/EvaluatedModelMapper.kt
Outdated
Show resolved
Hide resolved
plugins/reporters/evaluated-model/src/main/kotlin/EvaluatedModelMapper.kt
Outdated
Show resolved
Hide resolved
Only sort on serialization for human readability and reproducibility. Signed-off-by: Frank Viernau <[email protected]>
Returning a sorted set is no more necessary, because `ScanSummary` has been changed in a preceeding change to use a set for the copyright findings. Signed-off-by: Frank Viernau <[email protected]>
Using a mutable one is not needed. Signed-off-by: Frank Viernau <[email protected]>
Make the code consistent with the function below. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
license-findings-set
branch
from
7a019c5
to
0862259
Compare
sschuberth
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #6235, also needed by #6945.
Breaking change: If you rely on
LicenseFindings being comparable in the rules.kts or notifications.kts scripts, you'll have to adjust your scripts.