Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model: Remove the remaining uses of SortedSet / SortedMap from classes which get serialized #8705

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

model: Remove the remaining uses of SortedSet / SortedMap from classes which get serialized #8705

wants to merge 3 commits into from

Commits on Jun 18, 2024

  1. test(model): Make formatting of fragments construction consistent 

    Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3054d38 View commit details
    Browse the repository at this point in the history

  2. refactor(model): Use named arguments in a couple of constructor calls 

    Improve readability, and while at it make use of the default value for
scope roots in two of the calls.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    093f6b6 View commit details
    Browse the repository at this point in the history

  3. refactor(model): Stop using SortedSet for scopeRoots 

    Only sort on serialization for human readability and reproducibility.
Also, remove the now unused comparator, which was used only by tests
before.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a523522 View commit details
    Browse the repository at this point in the history