Skip to content

Commit

Permalink
🌱 Reduce confusion around codecov check status. (#3492)
Browse files Browse the repository at this point in the history
With our current upload setup, it will always show a drop of 6-7%.
This is confusing to contributors, so make the check always pass.
Also fixes the threshold for the patch coverage.

Signed-off-by: Spencer Schrock <[email protected]>
  • Loading branch information
spencerschrock authored Sep 19, 2023
1 parent 893a472 commit 93edfbc
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,15 @@ coverage:
status:
project:
default:
enabled: true
# allowed to drop coverage and still result in a "success" commit status
threshold: null
informational: true
if_not_found: success
if_no_uploads: success
if_ci_failed: error
patch:
default:
enabled: true
threshold: 90%
# patch coverage should be within 10% of existing coverage
target: auto
threshold: 10%
if_not_found: success
if_no_uploads: success
if_ci_failed: error
Expand Down

0 comments on commit 93edfbc

Please sign in to comment.