🐛 Use the proper repo for lombok. #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenottingham
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
|
Integration tests success for |
Codecov Report
@@ Coverage Diff @@
## main #2029 +/- ##
==========================================
+ Coverage 50.56% 53.19% +2.62%
==========================================
Files 87 87
Lines 7202 7202
==========================================
+ Hits 3642 3831 +189
+ Misses 3315 3119 -196
- Partials 245 252 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This switches the repo scanned for lombok.
https://deps.dev/maven/org.projectlombok%3Alombok doesn't show a scorecard.
My hypothesis is that's because this is scanning
github.com/rzwitserloot/lombok
which redirects to github.com/projectlombok/lombok
Assumption is that just scanning the actual project repo will fix this.
What is the current behavior?
Scores are indexed by the old rzwitserloot repo, even though it's scanning the projectlombok one.
What is the new behavior (if this is a feature change)?**
Scores are under the repo actually scanned.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?