-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add repository guidelines e.g., for project donations #4123
Conversation
Signed-off-by: Stephen Augustus <[email protected]>
Tagging @UlisesGascon for review on this, as he's actively running through the process in #3204, ossf/scorecard-monitor#74. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring the TODOs LGTM. Is your intent to remove them in this PR?
@spencerschrock — those TODOs need to be addressed in a follow-up. They're items that were present in the Kubernetes guidelines that we should solve for, but aren't blocking to bootstrap the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guidelines are clear to me. Thanks for the ping @justaugustus ❤️
|
||
Donated repositories must: | ||
|
||
- Adhere to the [requirements for all project repositories](#requirements) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minor comment (not a blocker), in practical terms, the only requirement that seems tricky with donated projects is the permissions (All privileges to the repository must be defined via GitHub teams
). When the project is transferred, the permissions are reset. Additionally, projects located in other organizations might have different team setups.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
ref: #4073, #3204, ossf/scorecard-monitor#74
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)