Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add repository guidelines e.g., for project donations #4123

Merged
merged 2 commits into from
May 30, 2024

Conversation

justaugustus
Copy link
Member

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

ref: #4073, #3204, ossf/scorecard-monitor#74

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@justaugustus justaugustus changed the title 📖 docs: Add repository guidelines e.g., for project donations 📖 Add repository guidelines e.g., for project donations May 24, 2024
@justaugustus
Copy link
Member Author

Tagging @UlisesGascon for review on this, as he's actively running through the process in #3204, ossf/scorecard-monitor#74.

Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the TODOs LGTM. Is your intent to remove them in this PR?

docs/repositories.md Show resolved Hide resolved
@justaugustus
Copy link
Member Author

Ignoring the TODOs LGTM. Is your intent to remove them in this PR?

@spencerschrock — those TODOs need to be addressed in a follow-up. They're items that were present in the Kubernetes guidelines that we should solve for, but aren't blocking to bootstrap the docs.

@justaugustus justaugustus enabled auto-merge (squash) May 30, 2024 12:29
@justaugustus justaugustus merged commit 16ed8a6 into ossf:main May 30, 2024
36 checks passed
@justaugustus justaugustus deleted the project-donations branch May 30, 2024 12:40
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidelines are clear to me. Thanks for the ping @justaugustus ❤️


Donated repositories must:

- Adhere to the [requirements for all project repositories](#requirements)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a minor comment (not a blocker), in practical terms, the only requirement that seems tricky with donated projects is the permissions (All privileges to the repository must be defined via GitHub teams). When the project is transferred, the permissions are reset. Additionally, projects located in other organizations might have different team setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants