Minimise build on snmalloc. #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EXCLUDE_FROM_ALL` target on `add_subdirectory` means that it will only build items that are required to build other targets. This means that it will not build the `memcpy` version that you are not using in this project, hence remove the issue with FORTIFY_SOURCE. This should also mildly improve your build times.
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EXCLUDE_FROM_ALLtarget onadd_subdirectorymeans that it will only build items that are required to build other targets. This means that it will not build thememcpyversion that you are not using in this project, hence remove the issue with FORTIFY_SOURCE. This should also mildly improve your build times.