Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple SPS/PPS, then pick the first one. #2544

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

duiniuluantanqin
Copy link
Member

No description provided.

@duiniuluantanqin duiniuluantanqin linked an issue Aug 19, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #2544 (dd5e6b8) into develop (85620a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2544   +/-   ##
========================================
  Coverage    59.18%   59.18%           
========================================
  Files          122      122           
  Lines        51724    51728    +4     
========================================
+ Hits         30611    30614    +3     
- Misses       21113    21114    +1     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/kernel/srs_kernel_codec.cpp | 90.07% <ø> (ø) | |'

Translated to English while maintaining the markdown structure:

| trunk/src/kernel/srs_kernel_codec.cpp | 90.07% <ø> (ø) | |
| trunk/src/utest/srs_utest_kernel.cpp | 98.49% <100.00%> (+<0.01%) | ⬆️ |
| trunk/src/protocol/srs_rtmp_handshake.cpp | 84.13% <0.00%> (-0.18%) | ⬇️ |


Continue to review full report at Codecov.

Legend - Click here to learn more
| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Translated to English while maintaining the markdown structure:

| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update 85620a3...dd5e6b8. Read the comment docs.

TRANS_BY_GPT3

@mypopydev
Copy link

Any special reason just pick the first one?

@duiniuluantanqin
Copy link
Member Author

duiniuluantanqin commented Aug 26, 2021

Any special reason just pick the first one?

Indeed, no official information was found, only found this: [https://stackoverflow.com/questions/20682275/h264-with-multiple-pps-and-sps].

Most decoders/muxers parse the first SPS/PPS as part of a setup process and ignore subsequent SPSs.

For streaming media, multiple SPS/PPS is meaningless. For example, if you want to change the resolution midway, you can simply place the latest SPS/PPS before the next IDR frame. Therefore, choosing the first or the last one does not make any difference.

TRANS_BY_GPT3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTMP: Pushing stream failed, indicating decode SPS.
5 participants