Kickoff publisher when stream is idle, which means no players. v6.0.31, v5.0.144 #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
force-pushed
the
develop
branch
25 times, most recently
from
be660c8
to
1fe12b8
Compare
winlinvip
reviewed
Feb 25, 2023
winlinvip
reviewed
Feb 25, 2023
winlinvip
reviewed
Feb 25, 2023
winlinvip
reviewed
Feb 25, 2023
winlinvip
reviewed
Feb 25, 2023
winlinvip
changed the title
winlinvip
reviewed
Mar 3, 2023
winlinvip
reviewed
Mar 3, 2023
winlinvip
reviewed
Mar 3, 2023
winlinvip
reviewed
Mar 3, 2023
winlinvip
changed the title
winlinvip
approved these changes
Mar 4, 2023
|
This PR is part of #3420 |
winlinvip
changed the title
chundonglinlin
approved these changes
Mar 6, 2023
winlinvip
added a commit
that referenced
this pull request
Mar 6, 2023
…1, v5.0.144 (#3105) For some use scenario, the publisher is invited when player want to view the stream: 1. Publisher connect to system, but does not publish any stream to SRS yet. 2. Player connect to system and start to request the stream. 3. System notifies publisher to publish stream to SRS. 4. Player play the stream from SRS. Please notice that `system` means your business system, not SRS. This is what we called `on-demand-live-streaming`, so when the last player stop to view the stream, what happends? 1. System needs to notify publisher to stop publish. 2. Or, SRS disconnect the publisher when idle(the last player stops playing). This PR is for the solution 2, so that the cleanup is very simple, your system does not need to notify publisher to stop publish, because SRS has already disconnected the publihser. PICK 8fde036 --------- Co-authored-by: winlin <[email protected]> Co-authored-by: chundonglinlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some use scenario, the publisher is invited when player want to view the stream:
Please notice that
systemmeans your business system, not SRS.This is what we called
on-demand-live-streaming, so when the last player stop to view the stream, what happends?This PR is for the solution 2, so that the cleanup is very simple, your system does not need to notify publisher to stop publish, because SRS has already disconnected the publihser.