Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the usage of "transcode" in the "full.conf" file. v5.0.162, v6.0.56 #3596

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Improve the usage of "transcode" in the "full.conf" file. v5.0.162, v6.0.56 #3596

merged 4 commits into from
Jun 29, 2023

Conversation

duiniuluantanqin
Copy link
Member

@duiniuluantanqin duiniuluantanqin commented Jun 21, 2023 •
edited
Loading

Improve the usage of transcode in the full.conf file.

srs/trunk/src/app/srs_app_encoder.cpp

Lines 265 to 271 in 8c061fc

output = srs_string_replace(output, "[vhost]", req->vhost);
output = srs_string_replace(output, "[port]", srs_int2str(req->port));
output = srs_string_replace(output, "[app]", req->app);
output = srs_string_replace(output, "[stream]", req->stream);
output = srs_string_replace(output, "[param]", req->param);
output = srs_string_replace(output, "[engine]", engine->arg0());
output = srs_path_build_timestamp(output);

For #3548

@duiniuluantanqin duiniuluantanqin linked an issue Jun 21, 2023 that may be closed by this pull request
The on_connect hook is firing more than one time when sending the transcoder output to another vhost. #3548
Closed
@winlinvip winlinvip changed the title Improve the usage of "transcode" in the "full.conf" file. Improve the usage of "transcode" in the "full.conf" file. v5.0.162, v6.0.56 Jun 29, 2023
@winlinvip winlinvip merged commit 7ba59c3 into develop Jun 29, 2023
winlinvip pushed a commit that referenced this pull request Jun 29, 2023
@duiniuluantanqin @chundonglinlin
@xiaozhihong @winlinvip
Improve the usage of "transcode" in the "full.conf" file. v5.0.162, v…
3955d3f 
…6.0.56 (#3596)

---------

Co-authored-by: chundonglinlin <[email protected]>
Co-authored-by: john <[email protected]>
@winlinvip winlinvip deleted the fix_bug_issue_3548 branch July 28, 2023 08:40
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chundonglinlin chundonglinlin chundonglinlin approved these changes

@xiaozhihong xiaozhihong xiaozhihong approved these changes

Assignees
No one assigned
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The on_connect hook is firing more than one time when sending the transcoder output to another vhost.
4 participants
@duiniuluantanqin @xiaozhihong @chundonglinlin @winlinvip