Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bug fixes #3

Closed
wants to merge 2 commits into from
Closed

some bug fixes #3

wants to merge 2 commits into from

Conversation

tcpan
Copy link

@tcpan tcpan commented Jan 6, 2020

Hi,
I ran into a few bugs when trying to use the dropbox docker container, and I went ahead an fixed them (as far as I can tell):

  1. switched to ubuntu base image, as it is officially supported by dropbox and also does not cause some warnings observed via "docker logs"
  2. syntax of LABEL lines in Dockerfile was incorrect.
  3. DEBIAN_DRONTEND line has been changed to ARG - this makes the variable a build time variable only.
  4. installed tzdata, so that container can be started with --volume=/etc/timezone:/etc/timezone and --volume=/etc/localtime:/etc/localtime. This fixes the problem of host on local time zone and container defaulting to UTC. Dropbox probably is not checking time zones when comparing file timestamps, leading to file overwrites and data loss.

I ended up not using docker containers for dropbox, but thought I pass along these fixes. Please feel free to remove my username/email from the Dockerfile. Enjoy!

Tony

… so that DEBIAN_FRONTEND does not persist after build. ENH: cleanup after build to remove apt packages.
…and /etc/localtime mapped to host's versions inorder for times to be correct for dropbox.
@otherguy otherguy self-requested a review April 21, 2020 09:47
@otherguy otherguy self-assigned this Apr 21, 2020
@otherguy otherguy added enhancement New feature or request good first issue labels Apr 27, 2020
@otherguy otherguy mentioned this pull request Apr 27, 2020
@otherguy
Copy link
Owner

Hi @tcpan! Thank you for your feedback and the effort you put into improving this!

My LABEL syntax is actually valid (so is yours of course) but I prefer the one with spacing to make the Dockerfile more readable.

Especially thanks for the change to the DEBIAN_FRONTEND variable and the tzdata feature! I did not think of that but you are right that it's absolutely crucial!

Instead of editing your PR, I have integrated your changes into a new PR #7.

Thanks again for your contribution!

@otherguy otherguy closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants