Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Try to build wheels #138

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Try to build wheels #138

wants to merge 8 commits into from

Conversation

abitrolly
Copy link

@ovalhub
Copy link
Owner

ovalhub commented Nov 19, 2020 via email

@abitrolly
Copy link
Author

How do people download the wheel ?

From PyP after this this code is added.

env:
  global:
    - TWINE_USERNAME=__token__
    # Note: TWINE_PASSWORD is set to a PyPI API token in Travis settings
...
after_success:
  # if the release was tagged, upload them to PyPI
  - |
    if [[ $TRAVIS_TAG ]]; then
      python3 -m pip install twine
      python3 -m twine upload wheelhouse/*.whl
    fi

https://github.com/joerick/cibuildwheel/blob/master/examples/travis-ci-deploy.yml

What version of ICU is the PyICU wheel built with ?

Latest?

I wonder how Unicode in Python3 works. Does it link with some library like ICU?

@ovalhub
Copy link
Owner

ovalhub commented Nov 19, 2020 via email

@abitrolly
Copy link
Author

It should be the one installed by the os by default, usually not the latest. Are the ICU libs included in the wheel ?

I am not sure how it works. My assumption is that everything that wheels needs to work is statically linked. except base libs that are defined by manylinux1 or manylinux2010 standard (https://www.python.org/dev/peps/pep-0571/).

Builds are made in a container, no purpose of installing ICU there
@ovalhub
Copy link
Owner

ovalhub commented Nov 19, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants