This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Try to build wheels #138
Open
abitrolly
wants to merge
8
commits into
ovalhub:master
Choose a base branch
from
abitrolly:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Try to build wheels #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How do people download the wheel ?
What version of ICU is the PyICU wheel built with ?
… On Nov 18, 2020, at 22:51, Anatoli Babenia ***@***.***> wrote:
https://pypi.org/project/cibuildwheel/
You can view, comment on, or merge this pull request online at:
#138
Commit Summary
Try to build wheels
File Changes
M .travis.yml (4)
Patch Links:
https://github.com/ovalhub/pyicu/pull/138.patch
https://github.com/ovalhub/pyicu/pull/138.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
From PyP after this this code is added.
https://github.com/joerick/cibuildwheel/blob/master/examples/travis-ci-deploy.yml
Latest? I wonder how Unicode in Python3 works. Does it link with some library like ICU? |
On Nov 19, 2020, at 00:15, Anatoli Babenia ***@***.***> wrote:
How do people download the wheel ?
From PyP after this this code is added.
env:
global:
- TWINE_USERNAME=__token__
# Note: TWINE_PASSWORD is set to a PyPI API token in Travis settings
...
after_success:
# if the release was tagged, upload them to PyPI
- |
if [[ $TRAVIS_TAG ]]; then
python3 -m pip install twine
python3 -m twine upload wheelhouse/*.whl
fi
https://github.com/joerick/cibuildwheel/blob/master/examples/travis-ci-deploy.yml
What version of ICU is the PyICU wheel built with ?
Latest?
It should be the one installed by the os by default, usually not the latest. Are the ICU libs included in the wheel ?
I wonder how Unicode in Python3 works. Does it link with some library like ICU?
It has its own implementation, it does not use ICU.
… —
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I am not sure how it works. My assumption is that everything that wheels needs to work is statically linked. except base libs that are defined by |
Builds are made in a container, no purpose of installing ICU there
On Nov 19, 2020, at 08:09, Anatoli Babenia ***@***.***> wrote:
It should be the one installed by the os by default, usually not the latest. Are the ICU libs included in the wheel ?
I am not sure how it works. My assumption is that everything that wheels needs to work is statically linked. except base libs that are defined by manylinux1 or manylinux2010 standard (https://www.python.org/dev/peps/pep-0571/).
ICU is not going to be included, apparently, the pep says it below. I don't see how a prebuilt binary wheel is going to work since the version of icu that was used to build pyicu *must* match the version used when running.
The wheel's binary executables or shared objects may not link against externally-provided libraries except those in the following whitelist:
libgcc_s.so.1
libstdc++.so.6
libm.so.6
libdl.so.2
librt.so.1
libc.so.6
libnsl.so.1
libutil.so.1
libpthread.so.0
libresolv.so.2
libX11.so.6
libXext.so.6
libXrender.so.1
libICE.so.6
libSM.so.6
libGL.so.1
libgobject-2.0.so.0
libgthread-2.0.so.0
libglib-2.0.so.0
… —
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pypi.org/project/cibuildwheel/