fix(windows spawn): use cmd to call batch scripts #11355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
reviewed
May 28, 2024
|
|
||
| test("spaces in path and args", async () => { | ||
| const fields = "name scripts"; | ||
| expect(async () => { await $`npm pkg get ${fields}` }).not.toThrow(); |
There was a problem hiding this comment.
note that this test case does not reproduce the original issue, since bun install does not use .cmd files.
can you create a cmd script using tempDirWithFiles and running the a script with that directory in $PATH
|
Closing due to bitrot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #11328
How did you verify your code works?
I wrote automated tests
based on nodejs/node#7367 (comment)
not 100% sure about this, so count on your expertise